Re: [Crash-utility] ##freemail## Re: [PATCH] arm64: Fix for st->_stext_vmlinux not initialized when set VA_BITS_ACTUAL
Hi Qianli, Lianbo,
On 2022/06/30 14:41, qianli zhao wrote:
Hi, Lianbo
>
> On Wed, Jun 29, 2022 at 2:40 PM qianli zhao <zhaoqianligood(a)gmail.com> wrote:
>>
>> Hi,Lianbo
>> Thank you for your feedback.
>>
>> My kernel version is 5.10.59, and this issue is happened when the
>>
>> ramdumps without vmcoreinfo.
>
>
> Thank you for the explanation.
>
> It is important to point this(*without vmcoreinfo*) out in the patch log. That can
help understand this issue. Can you add it to the patch log?
sure, will update in next patchset
thanks, please add also a code comment, something like this:
/*
* The st->_stext_vmlinux is needed in arm64_init(PRE_GDB) when a
* dumpfile does not have vmcoreinfo and we use -m vabits_actual
* option, e.g. a raw RAM dumpfile.
*/
The patch looks good to me. I didn't think of any better way.
> In addition, I just got a dump file generated by the "virsh dump" command,
the dumpfile doesn't have the vmcoreinfo, and get the same errors
> with or without this patch, can you also double check? Maybe it is a similar issue.
I guess this will be another issue, as it looks like crash does
different behavior between RAMDUMP(KDUMP) and QEMU_MEM_DUMP_NO_VMCOREINFO.
so I can ack this patch for ramdumps with an updated commit log and
comment above.
Thanks,
Kazu