Re: [Crash-utility] [PATCH] Fix compile warnings

Bernhard Walle wrote: > > > > This patch makes me a litte nervous. I see that gdb 6.5 does this: > > > > else if (*augmentation == 'P') > > { > > /* Skip. Avoid indirection since we throw away the result. */ > > gdb_byte encoding = (*buf++) & ~DW_EH_PE_indirect; > > read_encoded_value (unit, encoding, buf, &bytes_read); > > buf += bytes_read; > > augmentation++; > > } > > > > Are they equivalent? > > Of course not. :) After thinking a bit I think the correct fix would > be: > > buf += size_of_encoded_value(*buf); > buf++; > > Do you aggree? I can't say with any confidence. I was trying to correlate the difference between the way it's done in gdb-6.5 vs 6.1, and got lost doing so...

Just curious -- how do you manage to get crash to run through that code path? (I put an exit() there, but can't seem to get there...)