Re: [Crash-utility] [PATCH v1 0/3] Add valgrind support for the crash's custom memory

Hi, HATAYAMA 在 2021年01月21日 12:47, crash-utility-request(a)redhat.com 写道: Thank you for the patchset. This changes are fine to me, but I have some other concerns as below: [1] add a simple description for supporting 'make valgrind' in README? [2] only pass the '-DVALGRIND' when using 'make valgrind' explicitly? For example: Step1: [root@dell-pet620-01 crash]# make valgrind TARGET: X86_64 CRASH: 7.2.9++ GDB: 7.6 cc -c -g -DX86_64 -DVALGRIND -DGDB_7_6 build_data.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security cc -c -g -DX86_64 -DVALGRIND -DGDB_7_6 tools.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security cc -c -g -DX86_64 -DVALGRIND -DGDB_7_6 global_data.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security ^^^^^^^^^ ... Step2: [root@dell-pet620-01 crash]# make lzo TARGET: X86_64 CRASH: 7.2.9++ GDB: 7.6 cc -c -g -DX86_64 -DVALGRIND -DLZO -DGDB_7_6 build_data.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security cc -c -g -DX86_64 -DVALGRIND -DLZO -DGDB_7_6 main.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security cc -c -g -DX86_64 -DVALGRIND -DLZO -DGDB_7_6 tools.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security ^^^^^^^^^^^^^^^ ... For the 'make lzo', the cflag '-DVALGRIND' is also added here after the step1, is that expected? BTW: this change could make the distribution add a new dependency of valgrind-devel package(A warm reminder). Thanks. Lianbo