Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members
----- Original Message -----
Hi Dave,
my bad.
Since you've made some simplifications in my patch, I hope it's ok to make
short patch.
Hi Alex,
This patch tests OK. I did make a few minor cosmetic changes, fixed the
"task" command so that the -R flag remains optional, and added some
verbiage to the struct, union, task, list and tree command help pages.
I look forward to using it in a real-life crash analysis, as it's a
pretty nifty enhancement. It's queued for crash-7.1.1:
https://github.com/crash-utility/crash/commit/042639e3f5580b503a44511be57...
Thanks very much,
Dave
--- a/symbols.c 2015-05-15 23:36:33.136710935 +0300
+++ b/symbols.c 2015-05-15 23:36:20.072710739 +0300
@@ -6260,7 +6260,7 @@
if (!((flags & DEREF_POINTERS) &&
dereference_pointer(addr, dm,
flags)))
{
- if (count_chars(dm->member,
'.'))
+ if (count_chars(dm->member,
'.') || count_chars(dm->member, '['))
parse_for_member_new(dm,
PARSE_FOR_DATA);
else
parse_for_member(dm,
PARSE_FOR_DATA);
Thanks,
Alexandr
--
Crash-utility mailing list
Crash-utility(a)redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility