Re: [Crash-utility] [PATCH 1/1] memory: Handle struct slab changes in linux-next

Hi Alex, -----Original Message----- > Since linux-next commit fe1e19081321 ("mm: Split slab into its own type"), > the struct slab is used for both SLAB and SLUB. Therefore, don't depend > on the non-presence of the struct slab to decide whether SLAB implementation > should be chosen and use the member variable "cpu_slab" of the struct > kmem_cache instead, it should be present only in SLUB. > > Signed-off-by: Alexander Egorenkov <egorenar(a)linux.ibm.com&gt; Thanks for the early fix as always. It looks good to me. We'd like to add the error message to the commit log: --- Without the patch, crash fails to start with the error message: crash: invalid structure member offset: kmem_cache_s_num FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init() --- Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt;

btw, kmem -s does not work well with the current linux-next. I've not looked into it yet, any patches would be helpful.