[Crash-utility] Re: [PATCH] Fix dis -lr xxx+0x1 not showing target address instruction

On Sat, Feb 14, 2026 at 8:43 PM Lianbo Jiang <lijiang(a)redhat.com&gt; wrote: Indeed. We will disassemble all instructions of the function, but only take the first few instructions for output, that would be a waste. This one also have some problems: crash> dis -r rb_next+0 <<----should output 1 instruction to include "rb_next+0" crash> dis -r rb_next+1 <<---- OK 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx crash> dis -r rb_next+2 <<---- should output 3 instruction, because "rb_next+2" is not included by any outputted instructions. 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx crash> dis -r rb_next+3 <<---- OK 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx 0xffffffff81329604 <rb_next+4>: mov %rsp,%rbp crash> dis -r rb_next+4 <<---- OK 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx 0xffffffff81329604 <rb_next+4>: mov %rsp,%rbp crash> dis -r rb_next+5 <<---- OK 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx 0xffffffff81329604 <rb_next+4>: mov %rsp,%rbp 0xffffffff81329607 <rb_next+7>: cmp %rdx,%rdi In addition, the 2 in roundup() is a magic number to me. How about the following modification: if (reverse) sprintf(buf5, "x/%ldi 0x%lx", - (target - req->addr) ? target - req->addr : 1, + abs(target - req->addr) + 1, req->addr); crash> dis -r rb_next+0 0xffffffff81329600 <rb_next>: push %rbp crash> dis -r rb_next+1 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx crash> dis -r rb_next+2 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx 0xffffffff81329604 <rb_next+4>: mov %rsp,%rbp crash> dis -r rb_next+3 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx 0xffffffff81329604 <rb_next+4>: mov %rsp,%rbp crash> dis -r rb_next+4 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx 0xffffffff81329604 <rb_next+4>: mov %rsp,%rbp crash> dis -r rb_next+5 0xffffffff81329600 <rb_next>: push %rbp 0xffffffff81329601 <rb_next+1>: mov (%rdi),%rdx 0xffffffff81329604 <rb_next+4>: mov %rsp,%rbp 0xffffffff81329607 <rb_next+7>: cmp %rdx,%rdi Thanks, Tao Liu