Re: [Crash-utility] [PATCH 0/1] Fix for XArray/radix_tree rework on linux-next
Hi Dave,
On Thu, 21 Mar 2019 11:46:33 -0400 (EDT)
Dave Anderson <anderson(a)redhat.com> wrote:
----- Original Message -----
> Hi Dave,
>
> crash currently fails on linux-next kernel due to another radix-tree rework.
> The patch attached fixes this.
>
> BTW, is there an 'official policy' about fixing linux-next issues, as
commits
> can be changed/dropped on their way to the linux repo?
Hi Philipp,
Not really, although since your fixes will not affect the current mechanism,
they should be safe to apply.
Ok. I'm mainly asking because we are building up an environment for automated
(kernel) tests on s390, including tests on linux-next. In this context we also
have a test if crash starts with a given kernel. That's why I expect more
fixes/bugs like this to come in the future.
I'm not really sure what's the best way to handle them. On one hand it would be
nice when crash could read those kernels. On the other I don't want to clutter
the code with fixes for patches that don't make it upstream. Do you have a
preferred way to handle similar bugs in the future?
But I note that your changes only address the basic task
initialization
sequence and the "bpf" and the "ipcs" commands. Did you also look
into the "files -p", "irq" and "tree -t -p" options?
You are right I missed those. "files -p" however seems to work fine with the
patch I sent. For the other two I'll prepare a v2.
Thanks
Philipp
Thanks,
Dave
PS: the
"
>
> Thanks
> Philipp
>
> Philipp Rudo (1):
> Fix for XArray/radix_tree rework on linux-next
>
> bpf.c | 7 ++++++-
> ipcs.c | 5 ++++-
> task.c | 15 +++++++++++----
> 3 files changed, 21 insertions(+), 6 deletions(-)
>
> --
> 2.16.4
>
>