[Crash-utility] Re: [PATCH 1/2] RISCV64: fix wrong information of, PUD, PMD and PTE - SA48(4K page)

Hi, Austin Thank you for the patch. For the time being, I have no the RISCV64 environment for testing, just did the build, and the changes are good to me. So: Ack for the [PATCH 1/2] and [PATCH 2/2]. Lianbo On 1/15/26 4:27 PM, devel-request(a)lists.crash-utility.osci.io wrote: > Date: Tue, 13 Jan 2026 10:54:01 +0900 > From: Austin Kim&lt;austindh.kim(a)gmail.com&gt; > Subject: [Crash-utility] [PATCH 1/2] RISCV64: fix wrong information of > PUD, PMD and PTE - SA48(4K page) > To:devel@lists.crash-utility.osci.io > Cc:austindh.kim@gmail.com > Message-ID: <aWWluWUXmh9JuGQx@adminpc-PowerEdge-R7525> > Content-Type: text/plain; charset=us-ascii > > As for SA48(4K page) in RISC-V based vmcore, 'vtop address' command > produces the misleading information, including PUD, PMD, PTE. > > This commit is based on the following previous commit: > > commit 536a0d78f1fa ("RISCV64: fix wrong information of PMD and PTE - SA39(4K page)") > > Signed-off-by: Austin Kim&lt;austindh.kim(a)gmail.com&gt; > --- > riscv64.c | 37 ++++++++++++++++++------------------- > 1 file changed, 18 insertions(+), 19 deletions(-) > > diff --git a/riscv64.c b/riscv64.c > index 6b89f0b..4400d5c 100644 > --- a/riscv64.c > +++ b/riscv64.c > @@ -1210,10 +1210,9 @@ static int > riscv64_vtop_4level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr, int verbose) > { > ulong *pgd_ptr, pgd_val; > - ulong pud_val; > - ulong pmd_val; > - ulong pte_val, pte_pfn; > - ulong pt_phys; > + ulong pud_base, pud_addr, pud_val; > + ulong pmd_base, pmd_addr, pmd_val; > + ulong pte_base, pte_addr, pte_val, pte_pfn; > > if (verbose) > fprintf(fp, "PAGE DIRECTORY: %lx\n", (ulong)pgd); > @@ -1227,36 +1226,36 @@ riscv64_vtop_4level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr, int verbose) > if (!pgd_val) > goto no_page; > pgd_val &= PTE_PFN_PROT_MASK; > - pt_phys = (pgd_val >> _PAGE_PFN_SHIFT) << PAGESHIFT(); > + pud_base = (pgd_val >> _PAGE_PFN_SHIFT) << PAGESHIFT(); > > /* PUD */ > - FILL_PUD(PAGEBASE(pt_phys), PHYSADDR, PAGESIZE()); > - pud_val = ULONG(machdep->pud + PAGEOFFSET(sizeof(pud_t) * > - pud_index_l4_4k(vaddr))); > + FILL_PUD(PAGEBASE(pud_base), PHYSADDR, PAGESIZE()); > + pud_addr = pud_base + sizeof(pud_t) * pud_index_l4_4k(vaddr); > + pud_val = ULONG(machdep->pud + PAGEOFFSET(pud_addr)); > if (verbose) > - fprintf(fp, " PUD: %016lx => %016lx\n", pt_phys, pud_val); > + fprintf(fp, " PUD: %016lx => %016lx\n", pud_addr, pud_val); > if (!pud_val) > goto no_page; > pud_val &= PTE_PFN_PROT_MASK; > - pt_phys = (pud_val >> _PAGE_PFN_SHIFT) << PAGESHIFT(); > + pmd_base = (pud_val >> _PAGE_PFN_SHIFT) << PAGESHIFT(); > > /* PMD */ > - FILL_PMD(PAGEBASE(pt_phys), PHYSADDR, PAGESIZE()); > - pmd_val = ULONG(machdep->pmd + PAGEOFFSET(sizeof(pmd_t) * > - pmd_index_l4_4k(vaddr))); > + FILL_PMD(PAGEBASE(pmd_base), PHYSADDR, PAGESIZE()); > + pmd_addr = pmd_base + sizeof(pmd_t) + pmd_index_l4_4k(vaddr); > + pmd_val = ULONG(machdep->pmd + PAGEOFFSET(pmd_addr)); > if (verbose) > - fprintf(fp, " PMD: %016lx => %016lx\n", pt_phys, pmd_val); > + fprintf(fp, " PMD: %016lx => %016lx\n", pmd_addr, pmd_val); > if (!pmd_val) > goto no_page; > pmd_val &= PTE_PFN_PROT_MASK; > - pt_phys = (pmd_val >> _PAGE_PFN_SHIFT) << PAGESHIFT(); > + pte_base = (pmd_val >> _PAGE_PFN_SHIFT) << PAGESHIFT(); > > /* PTE */ > - FILL_PTBL(PAGEBASE(pt_phys), PHYSADDR, PAGESIZE()); > - pte_val = ULONG(machdep->ptbl + PAGEOFFSET(sizeof(pte_t) * > - pte_index_l4_4k(vaddr))); > + FILL_PTBL(PAGEBASE(pte_base), PHYSADDR, PAGESIZE()); > + pte_addr = pte_base + sizeof(pte_t) * pte_index_l4_4k(vaddr); > + pte_val = ULONG(machdep->ptbl + PAGEOFFSET(pte_addr)); > if (verbose) > - fprintf(fp, " PTE: %lx => %lx\n", pt_phys, pte_val); > + fprintf(fp, " PTE: %lx => %lx\n", pte_addr, pte_val); > if (!pte_val) > goto no_page; > pte_val &= PTE_PFN_PROT_MASK; > -- 2.34.1 -- Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki