Re: [Crash-utility] [PATCH] dis: Consolidate cmd_dis
----- Original Message -----
On Tue 2015-08-04 14:20 -0400, Dave Anderson wrote:
> > Hi Dave,
> >
> > No functionality change (hopefully). This patch is essentially a clean up
> > in preparation to introduce the "-f" option.
> >
> > Please let me know your thoughts.
>
> Honestly, I've looked at the patch both in text mode and in a graphical
> diff, and I have to say, it's really difficult to understand exactly what
> the patch accomplishes. Things seem to work as expected AFAICT.
I wanted to remove most of code duplication and somewhat reduce the
complexity of the function. This is the sole purpose of this patch.
With regards to the "-f" option feature, I would prefer to build on this
version.
--
Aaron Tomlin
OK. I did notice that it managed to cut ~70 lines. I'll do a side-by-side
comparison sanity check and continue testing it.
Anyway, the -f implementation on top of it should be fairly trivial, correct?
It should essentially be the same as GNU_FUNCTION_ONLY, but with an additional
"continue" in the lower while loop until curaddr reaches the starting address,
right?
Dave