On Wed, 2011-03-23 at 18:21 +0800, Lai Jiangshan wrote:
O
> +
> static int save_ftrace_printk(int fd)
> {
> - struct syment *s, *e;
> + struct kernel_list_head *mod_fmt;
> + struct syment *s, *e, *b;
> long bprintk_fmt_s, bprintk_fmt_e;
> - char string[4096];
> long *address;
> - size_t i, count;
> + size_t i, count, len;
>
This "len" is unused and cause the compiler warning:
gcc -Wall -I/usr/include/crash -nostartfiles -shared -rdynamic -o trace.so trace.c -fPIC
-DX86_64
trace.c: In function ‘save_ftrace_printk’:
trace.c:1918:19: warning: unused variable ‘len’
Hmm, that must have been left over from one of my "variations".
I can fix it and apply the patches to the crash-trace-command git tree,
but these patches will be also applied to the upstream crash utility by Dave,
Could you resend the patches with the fix.
I'll fix it. As I also found that patch 3 fixes a bug in patch 2. That
fix belongs in patch 2.
I'll resend later today.
Thanks for the review!
-- Steve