[Crash-utility] Re: warning when compiling xen_hyper_command.c with "make warn" and gcc 4.1.1
Hi Dave,
Sorry for delayed reply. I just returned from a long off.
Oops. yes, this must be "+=" . (Humm, it seems no warning
with gcc 3.3)
The fix is easy, but I will reveiw a little more.
Thanks.
On Tue, 02 Jan 2007 17:01:45 -0500
Dave Anderson <anderson(a)redhat.com> wrote:
Hello Oda-san,
I just noticed this warning message when compiling xen_hyper_command.c
with gcc 4.1.1:
$ make warn
...
cc -c -g -DX86 -D_FILE_OFFSET_BITS=64 xen_hyper_command.c -Wall -Wstrict-prototypes
-Wmissing-prototypes
xen_hyper_command.c: In function show_xen_hyper_dumpinfo:
xen_hyper_command.c:426: warning: value computed is not used
...
$
Here is the code it is referring to:
424 addr = (ulong)note_buf +
425 XEN_HYPER_OFFSET(ELF_Prstatus_pr_utime);
426 for (i = 0; i < 4; i++, addr+XEN_HYPER_SIZE(ELF_Timeval)) {
I'm presuming that it should be: "addr+=XEN_HYPER_SIZE(ELF_Timeval)?
Dave
--
Itsuro ODA <oda(a)valinux.co.jp>