Re: [Crash-utility] [PATCH] Add ELF core dump support for s390x
Hi Dave,
On Fri, 2010-02-12 at 10:41 -0500, Dave Anderson wrote:
----- "Dave Anderson" <anderson(a)redhat.com> wrote:
> If you're happy with the changes above, I can do it here, make sure
> it compiles, and queue it for the next release.
Here's my proposed patch, along with cleanups for these compiler warnings:
s390x.c: In function 's390x_cpu_get':
s390x.c:91: warning: unused variable 'nt_prefix'
s390x.c: In function 's390x_back_trace_cmd':
s390x.c:762: warning: unused variable 'cpu'
s390x.c: In function 's390x_cpu_get'
s390x.c:104: warning: control reaches end of non-void function
s390x.c:650: warning: ‘s390x_cpu_of_task’ defined but not used
Thanks, I forgot to switch on WARNING_OPTIONS in my Makefile.
BTW, the second stanza in the patch to s390x.c may require
hand-patching --
your original didn't apply on my current tree.
Anyway, does this work for you?
Works for me! I would put the definitions from defs.h to s390x.c.
One thing left: Please remove the following debug printf:
+.------.-------if (s390x_cpu_vec[i].prefix == prefix) {
+.------.-------.-------fprintf(fp, "GOT: %i\n", i);
<<<<<<<
+.------.-------.-------return &s390x_cpu_vec[i];
+.------.-------}
Michael