[Crash-utility] Re: [PATCH] vmcoreinfo: read vmcoreinfo using 'vmcoreinfo_data' when unavailable in elf note

On Wed, Jul 23, 2025 at 7:09 PM Aditya Gupta <adityag(a)linux.ibm.com&gt; wrote: I tried your repo, and the build failed: kernel.c: In function ‘is_vmcoreinfo_empty’: kernel.c:11982:21: error: invalid use of undefined type ‘struct diskdump_data’ 11982 | if (dd && dd->sub_header_kdump) | ^~ kernel.c:11983:27: error: invalid use of undefined type ‘struct diskdump_data’ 11983 | return (dd->sub_header_kdump->size_vmcoreinfo == 0); | ^~ kernel.c:11985:27: error: invalid use of undefined type ‘struct vmcore_data’ 11985 | return (nd->size_vmcoreinfo == 0); | ^~ make[5]: *** [Makefile:421: kernel.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [Makefile:2237: gdb] Error 2 make[3]: *** [Makefile:11028: all-gdb] Error 2 make[2]: *** [Makefile:1034: all] Error 2 crash build failed make[1]: *** [Makefile:316: gdb_merge] Error 1 make: *** [Makefile:307: all] Error 2 I'm afraid that needs more changes. BTW: if there are significant code changes, let's try renaming the is_vmcoreinfo_empty() to is_netdump/diskdump_vmcoreinfo_empty(), and calling them separately in netdump.c/diskdump.c. Anyway, this depends on your tests, let's see which one is simpler and more readable. Thanks Lianbo