Re: [Crash-utility] [PATCH] add a new command: ipcs
----- Original Message -----
Hello Dave,
At 2012-4-11 21:58, Dave Anderson wrote:
> Then, if the command is eventually accepted as a built-in, it will
> be a simple matter of removing the stuff shown above, changing
> all the_OFFSET_() and_SIZE_() callers to OFFSET() and SIZE(), and
> adding the members to the offset_table and size_table structures.
I know I must post it as an extension module at first. But I still have
concern about how it will be accepted as a build-in. To what extent, it
is good enough to be accepted? And I think I need to do some effort to
accelerate the progress. Would you please give some suggestion?
The acceptance criteria is purely subjective on my part, so there are
no set guidelines as to what is "good enough" to be accepted.
However, please consider that the last time a new command was added to
the crash utility was the "extend" command back in August 2001.
The extension module facility was added so that users could write their
own commands for whatever private purposes they were working on without
having to re-patch the base crash utility each time a new version came
out. And at the same time the base crash utility could remain simpler
and more maintainable, while affording the flexibility to those who are
inclined to write their own commands.
Dave