Re: [Crash-utility] Patch to add comments

Dave Anderson <anderson(a)redhat.com&gt; a écrit : > > > ----- Original Message ----- >> >> >> Hello Dave, >> A small cosmetic pach to add comments in the crash flow. >> Of course we may use !# to do this, but to call a shell just for a >> comment seems rather hard ? > > True -- but your patch that makes "#" an actual command is > way-overkill. > > Why not do this: > > --- main.c 20 Mar 2012 18:11:46 -0000 1.130 > +++ main.c 10 Apr 2012 13:59:45 -0000 > @@ -768,6 +768,9 @@ exec_command(void) > if (is_datatype_command()) > goto reattempt; > > + if (STRNEQ(args[0], "#")) > + return; > + > if (!(pc->flags & MINIMAL_MODE) && > is_gdb_command(TRUE, FAULT_ON_ERROR)) > goto reattempt; > > Dave > > > > -- > Crash-utility mailing list > Crash-utility(a)redhat.com > https://www.redhat.com/mailman/listinfo/crash-utility > Thanks, simple is better! Nevertheless, do we keep something in the help file or do we just "know" the way to push comment ? Olivier