Re: [Crash-utility] [RFC PATCH 15/15] mod: Change "BASE" on header to "TEXT_BASE" to clarify

On Thu, May 11, 2023 at 12:35 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com&gt; wrote: This is a simple fix, could you please put the [patch 15/15] to [patch 01/15] together? BTW: I saw several indent issues in these patches, and also a warning as below: symtab.c: In function ‘void gdb_command_funnel_1(gnu_request*)’: symtab.c:7519:64: warning: ‘%lx’ directive writing between 1 and 16 bytes into a region of size between 10 and 73 [-Wformat-overflow=] 7519 | sprintf(buf, " -s %s 0x%lx", secname, lm->mod_section_data[i].addr); | ^~~ symtab.c:7519:54: note: directive argument in the range [1, 18446744073709551615] 7519 | sprintf(buf, " -s %s 0x%lx", secname, lm->mod_section_data[i].addr); | ^~~~~~~~~~~~~~ In addition, is it possible to put these fixes into their corresponding patches in the next post? I know it might be additional work, but it is very helpful for maintaining and reviewing them. Thanks. Lianbo mkstring(buf3, maxsizelen, RJUST, "SIZE"));