Re: [Crash-utility] minor bug in get_text_init_space
----- "Dave Anderson" <anderson(a)redhat.com> wrote:
----- "Per Fransson" <perr.fransson.ml(a)gmail.com>
wrote:
> Hi,
>
> I believe the ARM support introduced a minor issue in the function
> get_text_init_space(). As it stands, the error "cannot determine text
> init space" can only occur when machine_type("ARM") is true. Here a
> suggested fix.
>
> Regards,
> Per
Definitely a bug -- thanks for catching that.
I remember looking at that ARM-support patch submission and thinking
that for maintainability/sanity purposes it should probably just be
separated out entirely for ARM.
Like this:
--- symbols.c 7 Sep 2010 20:46:53 -0000 1.214
+++ symbols.c 29 Sep 2010 13:52:37 -0000
@@ -489,9 +489,11 @@
if (pc->flags & SYSMAP)
return;
- if (((section = get_kernel_section(".text.init")) == NULL) &&
- ((section = get_kernel_section(".init.text")) == NULL) &&
- (machine_type("ARM") && (section =
get_kernel_section(".init")) == NULL)) {
+ if (machine_type("ARM"))
+ section = get_kernel_section(".init");
+ else if ((section = get_kernel_section(".text.init")) == NULL)
+ section = get_kernel_section(".init.text");
+ if (!section) {
error(WARNING, "cannot determine text init space\n");
return;
}
Thanks again Per,
Dave