Re: [Crash-utility] [PATCH] Fix "fuser" command to properly deal with an invalid argument
Hi, Kazu
Sorry for the late reply, I was offline last Friday.
On Mon, Apr 10, 2023 at 9:10 AM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com>
wrote:
Hi Lianbo,
Let me summarize my current suggestion:
(1) make the "fuser" command do not accept an obviously invalid
argument, which is not a kvaddr and also not a full path.
(I think this can be done without additional options, with the check I
wrote.)
(2) add a note that the command does not expect an argument other than
an inode address and a full path, and if others are specified, the
output can be an unexpected one.
What do you think?
Thanks for your suggestions, Kazu.
This sounds good to me, it has fewer changes and gets enhanced for the
argument checking. We do not need to complicate a simple problem.
I will post v2 later(with your suggestions).
Thanks
Lianbo
Attachments:
- attachment.html (text/html — 1.3 KB)