4:28 a.m.
Hello Dave,
A small cosmetic pach to add comments in the crash flow.
Of course we may use !# to do this, but to call a shell just for a comment seems rather
hard ?
With !#, we have:
crash> !#
crash> !# sysrq-triger
crash> !#
crash> file_operations 0xffffffff81643300
struct file_operations {
owner = 0x0,
llseek = 0xffffffff81166b90 <noop_llseek>,
read = 0,
write = 0xffffffff812fa4b0 <write_sysrq_trigger>,
[...]
}After the introduction of the command #, we just have:
crash> #
crash> # sysrq-triger
crash> #
crash> file_operations 0xffffffff81643300
struct file_operations {
owner = 0x0,
llseek = 0xffffffff81166b90 <noop_llseek>,
read = 0,
write = 0xffffffff812fa4b0 <write_sysrq_trigger>,
[...]
}
9:07 a.m.
----- Original Message -----
Hello Dave,
A small cosmetic pach to add comments in the crash flow.
Of course we may use !# to do this, but to call a shell just for a
comment seems rather hard ?
True -- but your patch that makes "#" an actual command is way-overkill.
Why not do this:
--- main.c 20 Mar 2012 18:11:46 -0000 1.130
+++ main.c 10 Apr 2012 13:59:45 -0000
@@ -768,6 +768,9 @@ exec_command(void)
if (is_datatype_command())
goto reattempt;
+ if (STRNEQ(args[0], "#"))
+ return;
+
if (!(pc->flags & MINIMAL_MODE) &&
is_gdb_command(TRUE, FAULT_ON_ERROR))
goto reattempt;
Dave
9:33 a.m.
Dave Anderson <anderson(a)redhat.com> a écrit :
----- Original Message -----
>
>
> Hello Dave,
> A small cosmetic pach to add comments in the crash flow.
> Of course we may use !# to do this, but to call a shell just for a
> comment seems rather hard ?
True -- but your patch that makes "#" an actual command is way-overkill.
Why not do this:
--- main.c 20 Mar 2012 18:11:46 -0000 1.130
+++ main.c 10 Apr 2012 13:59:45 -0000
@@ -768,6 +768,9 @@ exec_command(void)
if (is_datatype_command())
goto reattempt;
+ if (STRNEQ(args[0], "#"))
+ return;
+
if (!(pc->flags & MINIMAL_MODE) &&
is_gdb_command(TRUE, FAULT_ON_ERROR))
goto reattempt;
Dave
--
Crash-utility mailing list
Crash-utility(a)redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
Thanks, simple is better!
Nevertheless, do we keep something in the help file or do we just
"know" the way to push comment ?
Olivier
----------------------------------------------------------------
Ce message a ete envoye par IMP, grace a l'Universite Paris Ouest.
9:44 a.m.
----- Original Message -----
Dave Anderson <anderson(a)redhat.com> a écrit :
>
>
> ----- Original Message -----
>>
>>
>> Hello Dave,
>> A small cosmetic pach to add comments in the crash flow.
>> Of course we may use !# to do this, but to call a shell just for a
>> comment seems rather hard ?
>
> True -- but your patch that makes "#" an actual command is
> way-overkill.
>
> Why not do this:
>
> --- main.c 20 Mar 2012 18:11:46 -0000 1.130
> +++ main.c 10 Apr 2012 13:59:45 -0000
> @@ -768,6 +768,9 @@ exec_command(void)
> if (is_datatype_command())
> goto reattempt;
>
> + if (STRNEQ(args[0], "#"))
> + return;
> +
> if (!(pc->flags & MINIMAL_MODE) &&
> is_gdb_command(TRUE, FAULT_ON_ERROR))
> goto reattempt;
>
> Dave
>
>
>
> --
> Crash-utility mailing list
> Crash-utility(a)redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
>
Thanks, simple is better!
Nevertheless, do we keep something in the help file or do we just
"know" the way to push comment ?
Olivier
A line should probably be added to the "help input" page,
which is the input_info[] string array in help.c.
Dave
4:30 a.m.
The patch with your advises.
Olivier
--------------------------------------------------
From: "Dave Anderson" <anderson(a)redhat.com>
Sent: Tuesday, April 10, 2012 4:44 PM
To: "Discussion list for crash utility usage,maintenance and development"
<crash-utility(a)redhat.com>
Subject: Re: [Crash-utility] Patch to add comments
----- Original Message -----
>
>
> Dave Anderson <anderson(a)redhat.com> a écrit :
>
> >
> >
> > ----- Original Message -----
> >>
> >>
> >> Hello Dave,
> >> A small cosmetic pach to add comments in the crash flow.
> >> Of course we may use !# to do this, but to call a shell just for a
> >> comment seems rather hard ?
> >
> > True -- but your patch that makes "#" an actual command is
> > way-overkill.
> >
> > Why not do this:
> >
> > --- main.c 20 Mar 2012 18:11:46 -0000 1.130
> > +++ main.c 10 Apr 2012 13:59:45 -0000
> > @@ -768,6 +768,9 @@ exec_command(void)
> > if (is_datatype_command())
> > goto reattempt;
> >
> > + if (STRNEQ(args[0], "#"))
> > + return;
> > +
> > if (!(pc->flags & MINIMAL_MODE) &&
> > is_gdb_command(TRUE, FAULT_ON_ERROR))
> > goto reattempt;
> >
> > Dave
> >
> >
> >
> > --
> > Crash-utility mailing list
> > Crash-utility(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/crash-utility
> >
> Thanks, simple is better!
> Nevertheless, do we keep something in the help file or do we just
> "know" the way to push comment ?
> Olivier
A line should probably be added to the "help input" page,
which is the input_info[] string array in help.c.
Dave
--
Crash-utility mailing list
Crash-utility(a)redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
5:21 a.m.
Sorry, but just after sending the patch with bash style comments "#", i was
thinking we could also have c style comments wiht "//". In that way, we may
choose comment style when we use colored syntax for crash.
Thanks.
--------------------------------------------------
From: "Dave Anderson" <anderson(a)redhat.com>
Sent: Tuesday, April 10, 2012 4:44 PM
To: "Discussion list for crash utility usage,maintenance and development"
<crash-utility(a)redhat.com>
Subject: Re: [Crash-utility] Patch to add comments
----- Original Message -----
>
>
> Dave Anderson <anderson(a)redhat.com> a écrit :
>
> >
> >
> > ----- Original Message -----
> >>
> >>
> >> Hello Dave,
> >> A small cosmetic pach to add comments in the crash flow.
> >> Of course we may use !# to do this, but to call a shell just for a
> >> comment seems rather hard ?
> >
> > True -- but your patch that makes "#" an actual command is
> > way-overkill.
> >
> > Why not do this:
> >
> > --- main.c 20 Mar 2012 18:11:46 -0000 1.130
> > +++ main.c 10 Apr 2012 13:59:45 -0000
> > @@ -768,6 +768,9 @@ exec_command(void)
> > if (is_datatype_command())
> > goto reattempt;
> >
> > + if (STRNEQ(args[0], "#"))
> > + return;
> > +
> > if (!(pc->flags & MINIMAL_MODE) &&
> > is_gdb_command(TRUE, FAULT_ON_ERROR))
> > goto reattempt;
> >
> > Dave
> >
> >
> >
> > --
> > Crash-utility mailing list
> > Crash-utility(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/crash-utility
> >
> Thanks, simple is better!
> Nevertheless, do we keep something in the help file or do we just
> "know" the way to push comment ?
> Olivier
A line should probably be added to the "help input" page,
which is the input_info[] string array in help.c.
Dave
--
Crash-utility mailing list
Crash-utility(a)redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
9:48 a.m.
----- Original Message -----
Sorry, but just after sending the patch with bash style comments
"#", i was
thinking we could also have c style comments wiht "//". In that way, we may
choose comment style when we use colored syntax for crash.
Thanks.
Sure, why not? Queued for crash-6.0.6.
Thanks,
Dave
--------------------------------------------------
From: "Dave Anderson" <anderson(a)redhat.com>
Sent: Tuesday, April 10, 2012 4:44 PM
To: "Discussion list for crash utility usage,maintenance and
development"
<crash-utility(a)redhat.com>
Subject: Re: [Crash-utility] Patch to add comments
>
>
> ----- Original Message -----
>>
>>
>> Dave Anderson <anderson(a)redhat.com> a écrit :
>>
>> >
>> >
>> > ----- Original Message -----
>> >>
>> >>
>> >> Hello Dave,
>> >> A small cosmetic pach to add comments in the crash flow.
>> >> Of course we may use !# to do this, but to call a shell just
>> >> for a
>> >> comment seems rather hard ?
>> >
>> > True -- but your patch that makes "#" an actual command is
>> > way-overkill.
>> >
>> > Why not do this:
>> >
>> > --- main.c 20 Mar 2012 18:11:46 -0000 1.130
>> > +++ main.c 10 Apr 2012 13:59:45 -0000
>> > @@ -768,6 +768,9 @@ exec_command(void)
>> > if (is_datatype_command())
>> > goto reattempt;
>> >
>> > + if (STRNEQ(args[0], "#"))
>> > + return;
>> > +
>> > if (!(pc->flags & MINIMAL_MODE) &&
>> > is_gdb_command(TRUE, FAULT_ON_ERROR))
>> > goto reattempt;
>> >
>> > Dave
>> >
>> >
>> >
>> > --
>> > Crash-utility mailing list
>> > Crash-utility(a)redhat.com
>> > https://www.redhat.com/mailman/listinfo/crash-utility
>> >
>> Thanks, simple is better!
>> Nevertheless, do we keep something in the help file or do we just
>> "know" the way to push comment ?
>> Olivier
>
> A line should probably be added to the "help input" page,
> which is the input_info[] string array in help.c.
>
> Dave
>
>
>
> --
> Crash-utility mailing list
> Crash-utility(a)redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
>
--
Crash-utility mailing list
Crash-utility(a)redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
4950
days inactive
4960
days old
devel@lists.crash-utility.osci.io
6 comments
3 participants
participants (3)
-
Dave Anderson -
Imap -
Olivier Daudel