----- Original Message -----
 The syment struct is not used for anything by the embedded GDB,
 so we can remove it completely.
 
 Signed-off-by: Petr Tesarik <ptesarik(a)suse.cz> 
There is a capability that allows you to continue to use an older
version of gdb with the current crash sources.  That's what the
setup_gdb_defaults() function in configure.c does if there's
a ".gdb" file placed in the top-level directory.  And given the
fact that gdb-6.1 and earlier does need the struct syment declaration,
defs.h can't be changed.
But yes, the declarations in gdb-7.0/gdb/symtab.c are superfluous.  
I never noticed -- I would have thought that the -Wall in the
gdb compile line would complain about it, but it doesn't.
Anyway, when changing the gdb-7.0-patch, I prefer that the patch 
be added to the end of the file as a discrete diff, especially
since there is already a subsequent change to symtab.c.  I'll
do that, so consider the symtab.c part of your patch queued for
next release.
Thanks,
  Dave
 
 ---
 defs.h | 5 ++---
 gdb-7.0.patch | 4 +---
 2 files changed, 3 insertions(+), 6 deletions(-)
 
 --- a/defs.h
 +++ b/defs.h
 @@ -1963,9 +1963,6 @@ struct alias_data { /* c
 retaddr[i] = 0; \
 }
 
 -#endif /* !GDB_COMMON */
 -
 -
 #define SYMBOL_NAME_USED (0x1)
 #define MODULE_SYMBOL (0x2)
 #define IS_MODULE_SYMBOL(SYM) ((SYM)->flags & MODULE_SYMBOL)
 @@ -1981,6 +1978,8 @@ struct syment {
 unsigned char pad2;
 };
 
 +#endif /* !GDB_COMMON */
 +
 #define NAMESPACE_INIT (1)
 #define NAMESPACE_REUSE (2)
 #define NAMESPACE_FREE (3)
 --- a/gdb-7.0.patch
 +++ b/gdb-7.0.patch
 @@ -468,7 +468,7 @@
 return returnval;
 }
 
 -@@ -4783,3 +4790,619 @@ Valid values are \"ask\", \"all\",
\"can
 +@@ -4783,3 +4790,617 @@ Valid values are \"ask\", \"all\",
\"can
 
 observer_attach_executable_changed
 (symtab_observer_executable_changed);
 }
 @@ -880,8 +880,6 @@
 + register struct objfile *objfile;
 + register struct minimal_symbol *m;
 + struct load_module *lm;
 -+ struct syment *sp;
 -+ struct syment *spx;
 + int external, subsequent, found;
 + off_t offset;
 + ulong value, adjusted;
 
 --
 Crash-utility mailing list
 Crash-utility(a)redhat.com
 
https://www.redhat.com/mailman/listinfo/crash-utility