----- "Robin Holt" <holt(a)sgi.com&gt; wrote: > On Fri, Jan 09, 2009 at 01:22:39PM -0500, Dave Anderson wrote: > > But for kdump vmcores, it seems that kdump_page_size() needs to > > be made smarter, although I'm not sure where would it get the > > page size -- vmcoreinfo? > > This was an ia64 kdump created vmcore. I am a little confused about the > difference, but that little tiny bit, I do know. > > Robin Now I'm confused -- if you're looking at an ia64 kdump vmcore, then why did your patch modify the diskdump code?

----- "Robin Holt" <holt(a)sgi.com&gt; wrote: > On Fri, Jan 09, 2009 at 01:41:27PM -0500, Dave Anderson wrote: > > > > ----- "Robin Holt" <holt(a)sgi.com&gt; wrote: > > > > > On Fri, Jan 09, 2009 at 01:22:39PM -0500, Dave Anderson wrote: > > > > But for kdump vmcores, it seems that kdump_page_size() needs to > > > > be made smarter, although I'm not sure where would it get the > > > > page size -- vmcoreinfo? > > > > > > This was an ia64 kdump created vmcore. I am a little confused about the > > > difference, but that little tiny bit, I do know. > > > > > > Robin > > > > Now I'm confused -- if you're looking at an ia64 kdump vmcore, then > > why did your patch modify the diskdump code? > > I don't know what I am doing. I found the code that was executing (love > that prinktf debugging), looked at what was going wrong, adjusted code > until it worked, quilt refresh'd and emailed. No -- you did the right thing. That patch looks good... But if you were to create your 64k-page kdump vmcore *uncompressed*, and then ran crash on a 16k-page host, then kdump_page_size() would set the page size to 16k, and I'm pretty sure all hell would break loose. That's something Bernhard must have addressed in his patch.