New subject: [PATCH] arm64: handle vabits_actual symbol missing case

Sunday, 11 December 2022

Thank you for the update, Pavankumar.

On Thu, Dec 8, 2022 at 1:08 PM <crash-utility-request(a)redhat.com&gt; wrote:
...
 Date: Thu, 8 Dec 2022 09:55:07 +0530
 From: Pavankumar Kondeti <quic_pkondeti(a)quicinc.com&gt;
 To: <crash-utility(a)redhat.com&gt;, <k-hagio-ab(a)nec.com&gt;
 Cc: <quic_ankban(a)quicinc.com&gt;, Pavankumar Kondeti
         <quic_pkondeti(a)quicinc.com&gt;
 Subject: [Crash-utility] [PATCH] arm64: handle vabits_actual symbol
         missing case
 Message-ID:
         <1670473507-29911-1-git-send-email-quic_pkondeti(a)quicinc.com&gt;
 Content-Type: text/plain

 After the commit 0d9b1ffefabe ("arm64: mm: make vabits_actual
 a build time constant if possible") introduced in v5.19
 Linux kernel, the crash will not find vabits_actual symbol
 if if VA_BITS <= 48. Add a fallback option to initialize VA_BITS   ^^^^

...
 based on the user supplied machdep option.

 Tested ramdumps loading in both 6.0 and 5.15 kernels.

 Signed-off-by: Pavankumar Kondeti <quic_pkondeti(a)quicinc.com&gt;
 ---
  arm64.c | 4 ++++
  1 file changed, 4 insertions(+)

 diff --git a/arm64.c b/arm64.c
 index c3e26a3..7125458 100644
 --- a/arm64.c
 +++ b/arm64.c
 @@ -4671,6 +4671,10 @@ arm64_calc_VA_BITS(void)
                 return;
         } else if (arm64_set_va_bits_by_tcr()) {
                 return;
 +       } else if (machdep->machspec->VA_BITS_ACTUAL) {
 +               machdep->machspec->VA_BITS =
machdep->machspec->VA_BITS_ACTUAL;
 +               machdep->machspec->VA_START =
_VA_START(machdep->machspec->VA_BITS_ACTUAL);
 +               return;
         }

Looks good to me, for the v2: Ack

Thanks.
Lianbo

...
         if (!(sp = symbol_search("swapper_pg_dir"))
&&
 --
 2.7.4 

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Re: [Crash-utility] [PATCH] arm64: handle vabits_actual symbol missing case