11:50 p.m.
On Thu, Nov 4, 2021 at 4:49 PM <crash-utility-request(a)redhat.com> wrote:
Date: Thu, 4 Nov 2021 08:47:57 +0000
From: HAGIO KAZUHITO(?????) <k-hagio-ab(a)nec.com>
To: "er.ankurbansal(a)gmail.com" <er.ankurbansal(a)gmail.com>
Cc: "Discussion list for crash utility usage, maintenance and
development" <crash-utility(a)redhat.com>
Subject: Re: [Crash-utility] [PATCH] arm64 : Update the
section_size_bits for latest kernel
Message-ID:
<
TYYPR01MB67775E90F3F2EF285ACF5E86DD8D9(a)TYYPR01MB6777.jpnprd01.prod.outlook.com
>
Content-Type: text/plain; charset="iso-2022-jp"
Hi Ankur,
Thanks for the patch.
-----Original Message-----
> correct the section_size_bits for kernel version >= 5.12
> becuase of linux upstream change
>
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
> 119a8ac8059416ec4
> (arm64/sparsemem: reduce SECTION_SIZE_BITS)
>
> Change-Id: I31b66fbfe421a02aa9f370ce7a615fbc70efcf2f
> ---
> arm64.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arm64.c b/arm64.c
> index 3dcbcc6..4a207fc 100644
> --- a/arm64.c
> +++ b/arm64.c
> @@ -1123,9 +1123,15 @@ arm64_get_section_size_bits(void)
> free(string);
> } else if (kt->ikconfig_flags & IKCONFIG_AVAIL) {
> if ((ret = get_kernel_config("CONFIG_MEMORY_HOTPLUG",
NULL)) == IKCONFIG_Y) {
> - if ((ret =
get_kernel_config("CONFIG_HOTPLUG_SIZE_BITS", &string)) == IKCONFIG_STR)
> + if (THIS_KERNEL_VERSION >= LINUX(5,12,0)){
> + if((ret =
get_kernel_config("CONFIG_ARM64_64K_PAGES", NULL)) == IKCONFIG_Y)
> + machdep->section_size_bits = 29;
> + else
> + machdep->section_size_bits = 27;
> + }
> + else if ((ret =
get_kernel_config("CONFIG_HOTPLUG_SIZE_BITS", &string)) ==
> IKCONFIG_STR)
Considering dumpfiles without vmcoreinfo and IKCONFIG too, it will be
better
to switch the default value of section_size_bits. We can use
machdep->pagesize
here, so how about this?
- machdep->section_size_bits = _SECTION_SIZE_BITS;
+ if (THIS_KERNEL_VERSION >= LINUX(5,12,0)) {
+ if (machdep->pagesize == 65536)
+ machdep->section_size_bits = 29;
+ else
+ machdep->section_size_bits = 27;
+ } else
+ machdep->section_size_bits = _SECTION_SIZE_BITS;
This change covers more scenarios and looks good to me. Could you please
update this patch? Ankur and Kazu.
Thanks.
Lianbo
12:28 a.m.
New subject: [PATCH] arm64 : Update the section_size_bits for latest kernel
Hi Lianbo, Ankur,
This change covers more scenarios and looks good to me. Could you
please update this patch? Ankur and Kazu.
I've updated, does this work well?
--
From 9d6fca4d951f8bbb8c83078339e092da2d2fb0e0 Mon Sep 17 00:00:00 2001
From: Kazuhito Hagio <k-hagio-ab(a)nec.com>
Date: Thu, 11 Nov 2021 15:20:52 +0900
Subject: [PATCH] arm64: Update SECTION_SIZE_BITS for kernels >= 5.12
Update the default SECTION_SIZE_BITS value for arm64 Linux 5.12
and later kernels that contain kernel commit f0b13ee23241
("arm64/sparsemem: reduce SECTION_SIZE_BITS").
Reported-by: Ankur Bansal <er.ankurbansal(a)gmail.com>
Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
---
arm64.c | 8 +++++++-
defs.h | 4 +++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arm64.c b/arm64.c
index 3dcbcc642fda..94681d1a37db 100644
--- a/arm64.c
+++ b/arm64.c
@@ -1116,7 +1116,13 @@ arm64_get_section_size_bits(void)
int ret;
char *string;
- machdep->section_size_bits = _SECTION_SIZE_BITS;
+ if (THIS_KERNEL_VERSION >= LINUX(5,12,0)) {
+ if (machdep->pagesize == 65536)
+ machdep->section_size_bits = _SECTION_SIZE_BITS_5_12_64K;
+ else
+ machdep->section_size_bits = _SECTION_SIZE_BITS_5_12;
+ } else
+ machdep->section_size_bits = _SECTION_SIZE_BITS;
if ((string = pc->read_vmcoreinfo("NUMBER(SECTION_SIZE_BITS)"))) {
machdep->section_size_bits = atol(string);
diff --git a/defs.h b/defs.h
index 971005596506..a2f30853a4b1 100644
--- a/defs.h
+++ b/defs.h
@@ -3261,7 +3261,9 @@ typedef signed int s32;
#define ARM64_STACK_SIZE (16384)
#define ARM64_IRQ_STACK_SIZE ARM64_STACK_SIZE
-#define _SECTION_SIZE_BITS 30
+#define _SECTION_SIZE_BITS 30
+#define _SECTION_SIZE_BITS_5_12 27
+#define _SECTION_SIZE_BITS_5_12_64K 29
#define _MAX_PHYSMEM_BITS 40
#define _MAX_PHYSMEM_BITS_3_17 48
#define _MAX_PHYSMEM_BITS_52 52
--
2.27.0
1:14 a.m.
New subject: [PATCH] arm64 : Update the section_size_bits for latest kernel
On Thu, Nov 11, 2021 at 2:29 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com>
wrote:
Hi Lianbo, Ankur,
> This change covers more scenarios and looks good to me. Could you please
update this patch? Ankur and Kazu.
I've updated, does this work well?
Thank you for the update, Kazu. It works well.
Acked-by: Lianbo Jiang <lijiang(a)redhat.com>
--
From 9d6fca4d951f8bbb8c83078339e092da2d2fb0e0 Mon Sep 17 00:00:00 2001
From: Kazuhito Hagio <k-hagio-ab(a)nec.com>
Date: Thu, 11 Nov 2021 15:20:52 +0900
Subject: [PATCH] arm64: Update SECTION_SIZE_BITS for kernels >= 5.12
Update the default SECTION_SIZE_BITS value for arm64 Linux 5.12
and later kernels that contain kernel commit f0b13ee23241
("arm64/sparsemem: reduce SECTION_SIZE_BITS").
Reported-by: Ankur Bansal <er.ankurbansal(a)gmail.com>
Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
---
arm64.c | 8 +++++++-
defs.h | 4 +++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arm64.c b/arm64.c
index 3dcbcc642fda..94681d1a37db 100644
--- a/arm64.c
+++ b/arm64.c
@@ -1116,7 +1116,13 @@ arm64_get_section_size_bits(void)
int ret;
char *string;
- machdep->section_size_bits = _SECTION_SIZE_BITS;
+ if (THIS_KERNEL_VERSION >= LINUX(5,12,0)) {
+ if (machdep->pagesize == 65536)
+ machdep->section_size_bits =
_SECTION_SIZE_BITS_5_12_64K;
+ else
+ machdep->section_size_bits =
_SECTION_SIZE_BITS_5_12;
+ } else
+ machdep->section_size_bits = _SECTION_SIZE_BITS;
if ((string = pc->read_vmcoreinfo("NUMBER(SECTION_SIZE_BITS)"))) {
machdep->section_size_bits = atol(string);
diff --git a/defs.h b/defs.h
index 971005596506..a2f30853a4b1 100644
--- a/defs.h
+++ b/defs.h
@@ -3261,7 +3261,9 @@ typedef signed int s32;
#define ARM64_STACK_SIZE (16384)
#define ARM64_IRQ_STACK_SIZE ARM64_STACK_SIZE
-#define _SECTION_SIZE_BITS 30
+#define _SECTION_SIZE_BITS 30
+#define _SECTION_SIZE_BITS_5_12 27
+#define _SECTION_SIZE_BITS_5_12_64K 29
#define _MAX_PHYSMEM_BITS 40
#define _MAX_PHYSMEM_BITS_3_17 48
#define _MAX_PHYSMEM_BITS_52 52
--
2.27.0
11:20 p.m.
New subject: [PATCH] arm64 : Update the section_size_bits for latest kernel
Thank you, Ankur and Kazu. Applied:
https://github.com/crash-utility/crash/commit/8246dce99dd23457e8c7a3fe960...
On Fri, Nov 12, 2021 at 3:14 PM lijiang <lijiang(a)redhat.com> wrote:
On Thu, Nov 11, 2021 at 2:29 PM HAGIO KAZUHITO(萩尾 一仁)
<k-hagio-ab(a)nec.com>
wrote:
> Hi Lianbo, Ankur,
>
> > This change covers more scenarios and looks good to me. Could you
> please update this patch? Ankur and Kazu.
>
> I've updated, does this work well?
>
>
Thank you for the update, Kazu. It works well.
Acked-by: Lianbo Jiang <lijiang(a)redhat.com>
> --
> From 9d6fca4d951f8bbb8c83078339e092da2d2fb0e0 Mon Sep 17 00:00:00 2001
> From: Kazuhito Hagio <k-hagio-ab(a)nec.com>
> Date: Thu, 11 Nov 2021 15:20:52 +0900
> Subject: [PATCH] arm64: Update SECTION_SIZE_BITS for kernels >= 5.12
>
> Update the default SECTION_SIZE_BITS value for arm64 Linux 5.12
> and later kernels that contain kernel commit f0b13ee23241
> ("arm64/sparsemem: reduce SECTION_SIZE_BITS").
>
> Reported-by: Ankur Bansal <er.ankurbansal(a)gmail.com>
> Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
> ---
> arm64.c | 8 +++++++-
> defs.h | 4 +++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arm64.c b/arm64.c
> index 3dcbcc642fda..94681d1a37db 100644
> --- a/arm64.c
> +++ b/arm64.c
> @@ -1116,7 +1116,13 @@ arm64_get_section_size_bits(void)
> int ret;
> char *string;
>
> - machdep->section_size_bits = _SECTION_SIZE_BITS;
> + if (THIS_KERNEL_VERSION >= LINUX(5,12,0)) {
> + if (machdep->pagesize == 65536)
> + machdep->section_size_bits =
> _SECTION_SIZE_BITS_5_12_64K;
> + else
> + machdep->section_size_bits =
> _SECTION_SIZE_BITS_5_12;
> + } else
> + machdep->section_size_bits = _SECTION_SIZE_BITS;
>
> if ((string = pc->read_vmcoreinfo("NUMBER(SECTION_SIZE_BITS)")))
{
> machdep->section_size_bits = atol(string);
> diff --git a/defs.h b/defs.h
> index 971005596506..a2f30853a4b1 100644
> --- a/defs.h
> +++ b/defs.h
> @@ -3261,7 +3261,9 @@ typedef signed int s32;
> #define ARM64_STACK_SIZE (16384)
> #define ARM64_IRQ_STACK_SIZE ARM64_STACK_SIZE
>
> -#define _SECTION_SIZE_BITS 30
> +#define _SECTION_SIZE_BITS 30
> +#define _SECTION_SIZE_BITS_5_12 27
> +#define _SECTION_SIZE_BITS_5_12_64K 29
> #define _MAX_PHYSMEM_BITS 40
> #define _MAX_PHYSMEM_BITS_3_17 48
> #define _MAX_PHYSMEM_BITS_52 52
> --
> 2.27.0
>
>
1055
days inactive
1060
days old
devel@lists.crash-utility.osci.io
3 comments
2 participants
participants (2)
-
HAGIO KAZUHITO(萩尾 一仁) -
lijiang