7:21 p.m.
----- "Bernhard Walle" <bwalle(a)suse.de> wrote:
* Executing crash without any parameter results in a segmentation
fault.
* Add a NULL check for pc->orig_namelist to avoid the segmentation fault.
Huh?
The crash utility's program_context structure doesn't even
have an "orig_namelist" member.
Is this perhaps a bug in the SUSE crash utility derivative?
Dave
Signed-off-by: Sachin Sant <sachinp(a)in.ibm.com>
Acked-by: Bernhard Walle <bwalle(a)suse.de>
1 file changed, 3 insertions(+)
symbols.c | 3 +++
diff --git a/symbols.c b/symbols.c
--- a/symbols.c
+++ b/symbols.c
@@ -266,6 +266,9 @@
error(NOTE, "gnu_debuglink file: %s\ncrc32: %lx\n",
contents, crc32);
+ if (pc->orig_namelist == NULL)
+ return FALSE;
+
if ((pc->debuginfo_file = (char *)
malloc(((strlen(pc->namelist) + strlen("/.debug/") +
+ strlen(".debug") + strlen(" /usr/lib/debug/boot/
"))*10)
6:32 a.m.
New subject: [PATCH] Fix segmentation fault
Dave Anderson wrote:
----- "Bernhard Walle" <bwalle(a)suse.de> wrote:
> * Executing crash without any parameter results in a segmentation fault.
> * Add a NULL check for pc->orig_namelist to avoid the segmentation fault.
>
Huh?
The crash utility's program_context structure doesn't even
have an "orig_namelist" member.
Is this perhaps a bug in the SUSE crash utility derivative?
Yup not a problem with upstream crash.
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
9:19 a.m.
New subject: [PATCH] Fix segmentation fault
* Sachin P. Sant [2009-01-15 11:02]:
Dave Anderson wrote:
> ----- "Bernhard Walle" <bwalle(a)suse.de> wrote:
>
>
>> * Executing crash without any parameter results in a segmentation fault.
>> * Add a NULL check for pc->orig_namelist to avoid the segmentation fault.
>>
>
> Huh?
>
> The crash utility's program_context structure doesn't even
> have an "orig_namelist" member.
>
> Is this perhaps a bug in the SUSE crash utility derivative?
>
>
Yup not a problem with upstream crash.
Yes, my fault. I was too fast in sending not upstreamed patches
upstream. :-|
Explanation: I have some patch to read gzip'd kernels (mainly for
ia64 /boot/vmlinuz and for x86 /boot/vmlinux.gz). That patch added the
orig_namelist member. Because I extract the /boot/vmlinux.gz to a
temporary file but need the orig_namelist to print out nice error
messages.
I always wanted to 'polish' that patch for upstream inclusion. Any
interest in that feature? Then I would have some motivation to finally
do. :-)
I've chosen that temporary uncompression in favor to replace all reads
and writes with zlib equivalents because it's just extremely less
intrusive.
Bernhard
--
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
"I have always wished that my computer would be as easy to use as my
telephone. My wish has come true. I no longer know how to use my
telephone." -- Bjarne Stroustrup
5726
days inactive
5727
days old
devel@lists.crash-utility.osci.io
3 comments
4 participants
participants (4)
-
Bernhard Walle -
Dave Anderson -
Robin Holt -
Sachin P. Sant