[Crash-utility] Re: [PATCH 1/v2] Fix "mount <address>"

Hi Georges, I'll reword the title of the patch when merge, other than that, LGTM, ack. Thanks, Tao Liu On Tue, Sep 30, 2025 at 5:42 PM Aureau, Georges (Kernel Tools ERT) <georges.aureau(a)hpe.com&gt; wrote: > > [PATCH 1/v2] Fix "mount <address>" > > The command "mount <address>" is failing on kernels without "super_block.s_files": > > crash> mount ff35d61d80200000 > mount: the super_block.s_files linked list does not exist in this kernel > mount: -f option not supported or applicable on this architecture or kernel > > The MOUNT_PRINT_FILES flags should only be passed when "super_block.s_files" > is available. > > Signed-off-by: Georges Aureau <georges.aureau(a)hpe.com&gt; > -- > diff --git a/filesys.c b/filesys.c > index 8d13807..b4d4f02 100644 > --- a/filesys.c > +++ b/filesys.c > @@ -1296,7 +1296,7 @@ cmd_mount(void) > * through it for each search argument entered. > */ > open_tmpfile(); > - show_mounts(0, MOUNT_PRINT_FILES | > + show_mounts(0, (VALID_MEMBER(super_block_s_files) ? MOUNT_PRINT_FILES : 0) | > (VALID_MEMBER(super_block_s_dirty) ? MOUNT_PRINT_INODES : 0), > namespace_context); > -- > Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io > To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io > https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ > Contribution Guidelines: https://github.com/crash-utility/crash/wiki