[Crash-utility] Re: [PATCH 2/2] symbols: fix the error belonging of the kernel modules symbols

On 2023/11/13 22:09, Tao Liu wrote: >> A few slight comments: >> >> - lm->mod_init_module_ptr should has the address if available, this can >> be used? > Sorry I didn't get your point. The value here is only used as a flag > to indicate if the .init. section has been freed or not. Since the > value is important, other place in crash also used it and read it > there, symbol.c:store_module_symbols_v2() . Do you mean to share the > value in different places so crash only read it once? Yes. For dumpfiles, it's always ok to use lm->mod_init_module_ptr. For live systems, if there is a change in module load status when "mod" command is run, reinit_modules() is executed. I think that a contradiction rarely happens. If it happens, crash will has internal contradictions (e.g. between "help -s" output and its load status) with the readmem() in add_symbol_file_kallsyms(). So I would prefer using lm->mod_init_module_ptr for consistency.

Thanks, Kazu >> - STRNEQ() is more preferable than direct strncmp() >> > Agreed, will get it updated in v2. > > Thanks, > Tao Liu > >> Thanks, >> Kazu