[Crash-utility] Re: [PATCH v2 1/1] make the MAX_MALLOC_BUFS customizable

Hi Shivang, On Wed, Dec 3, 2025 at 11:21 PM Shivang Upadhyay <shivangu(a)linux.ibm.com&gt; wrote: > the default value of MAX_MALLOC_BUFS is 3072, but can be changed with > command line with flag `--max-malloc-bufs`. > > Signed-off-by: Shivang Upadhyay <shivangu(a)linux.ibm.com&gt; > --- > defs.h | 1 + > main.c | 4 ++++ > tools.c | 9 ++++++--- > 3 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/defs.h b/defs.h > index ab4aee8..863baf9 100644 > --- a/defs.h > +++ b/defs.h > @@ -5608,6 +5608,7 @@ void exec_args_input_file(struct command_table_entry *, struct args_input_file * > /* > * tools.c > */ > +extern int MAX_MALLOC_BUFS; > FILE *set_error(char *); > int __error(int, char *, ...); > #define error __error /* avoid conflict with gdb error() */ > diff --git a/main.c b/main.c > index 71bcc15..e986792 100644 > --- a/main.c > +++ b/main.c > @@ -46,6 +46,7 @@ static struct option long_options[] = { > {"version", 0, 0, 0}, > {"buildinfo", 0, 0, 0}, > {"cpus", required_argument, 0, 0}, > + {"max-malloc-bufs", required_argument, 0, 0}, > {"no_ikconfig", 0, 0, 0}, > {"hyper", 0, 0, 0}, > {"p2m_mfn", required_argument, 0, 0}, > @@ -163,6 +164,9 @@ main(int argc, char **argv) > else if (STREQ(long_options[option_index].name, "cpus")) > kt->cpus_override = optarg; > > + else if (STREQ(long_options[option_index].name, "max-malloc-bufs")) > + MAX_MALLOC_BUFS = atoi(optarg); Thanks for your improvement! Do we need to set 3072 as the minimum value? like, MAX_MALLOC_BUFS = MAX_MALLOC_BUFS > 3072 ? MAX_MALLOC_BUFS : 3072. If user set a value like 1000, which is likely to make crash unusable, and a minimum value will prevent users from the mistakes.