[Crash-utility] Re: [PATCH] Fix the misleading uncompress error message

On Fri, Oct 24, 2025 at 3:45 PM lijiang <lijiang(a)redhat.com&gt; wrote: > > On Tue, Oct 7, 2025 at 7:37 PM <devel-request(a)lists.crash-utility.osci.io&gt; wrote: >> >> Date: Tue, 7 Oct 2025 16:52:40 +1300 >> From: Tao Liu <ltao(a)redhat.com&gt; >> Subject: [Crash-utility] [PATCH] Fix the misleading uncompress error >> message >> To: devel(a)lists.crash-utility.osci.io >> Cc: Tao Liu <ltao(a)redhat.com&gt; >> Message-ID: <20251007035240.28260-1-ltao(a)redhat.com&gt; >> Content-Type: text/plain; charset="US-ASCII"; x-default=true >> >> The "unxz" is missing for uncompressing fail message. Fix [1]. >> >> [1]: https://github.com/crash-utility/crash/issues/220 > > > Can you add the Resolves tag before Sob, E.g: > > Resolves: https://github.com/crash-utility/crash/issues/220 > Signed-off-by: Tao Liu <ltao(a)redhat.com&gt; > > And this looks good to me: Ack. Sure, I will update it when merge. Thanks, Tao Liu > > Thanks > Lianbo > >> >> >> Signed-off-by: Tao Liu <ltao(a)redhat.com&gt; >> --- >> symbols.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/symbols.c b/symbols.c >> index ee3cba1..e6af38b 100644 >> --- a/symbols.c >> +++ b/symbols.c >> @@ -4481,8 +4481,9 @@ is_compressed_kernel(char *file, char **tmp) >> } >> if (system(command) < 0) { >> please_wait_done(); >> - error(INFO, "%s of %s failed\n", >> - type == GZIP ? "gunzip" : "bunzip2", file); >> + error(INFO, "%s of %s failed\n", >> + type == GZIP ? "gunzip" : >> + (type == BZIP2 ? "bunzip2" : "unxz"), file); >> free(tempname); >> return FALSE; >> } >> -- >> 2.47.0