Re: [Crash-utility] [PATCH] dis: Consolidate cmd_dis
On Tue 2015-08-04 14:20 -0400, Dave Anderson wrote:
> Hi Dave,
>
> No functionality change (hopefully). This patch is essentially a clean up
> in preparation to introduce the "-f" option.
>
> Please let me know your thoughts.
Honestly, I've looked at the patch both in text mode and in a graphical
diff, and I have to say, it's really difficult to understand exactly what
the patch accomplishes. Things seem to work as expected AFAICT.
I wanted to remove most of code duplication and somewhat reduce the
complexity of the function. This is the sole purpose of this patch.
With regards to the "-f" option feature, I would prefer to build on this
version.
--
Aaron Tomlin