[Crash-utility] Re: [PATCH] Revert "Fix the issue of "page excluded" messages flooding"
On Tue, Jul 29, 2025 at 10:33 AM Shivang Upadhyay <shivangu(a)linux.ibm.com>
wrote:
This reverts commit e906eaca2b1a77fe9f8ba512484b4e914c303f11.
Please do not revert this one, I added the reason in patch log, and see the
read_diskdump():
if (!page_is_dumpable(pfn)) {
if ((dd->flags & (ZERO_EXCLUDED|ERROR_EXCLUDED)) ==
ERROR_EXCLUDED) {
if (CRASHDEBUG(8))
fprintf(fp, "read_diskdump: PAGE_EXCLUDED: "
"paddr/pfn: %llx/%lx\n",
(ulonglong)paddr, pfn);
return PAGE_EXCLUDED;
}
if (CRASHDEBUG(8))
fprintf(fp, "read_diskdump: zero-fill: "
"paddr/pfn: %llx/%lx\n",
(ulonglong)paddr, pfn);
memset(bufptr, 0, cnt);
return cnt;
}
For debugging, we can set debug 8 to identify issues.
Thanks
Lianbo
This above commit adjusted the log level of the missing page warning
to
a debug levels only. However, these log can be useful in identifying
issues with dump-generating tools like makedumpfile. This revert will
increase their visibility back to normal.
The underlying issue was resolved by commit 2c69f93 ("gdb: disable
dt_debug lookup by gdb inside the vmcore").
Cc: Lianbo Jiang <lijiang(a)redhat.com>
Cc: Sourabh Jain <sourabhjain(a)linux.ibm.com>
Signed-off-by: Shivang Upadhyay <shivangu(a)linux.ibm.com>
---
memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/memory.c b/memory.c
index 400d31a..5cb8b58 100644
--- a/memory.c
+++ b/memory.c
@@ -2506,7 +2506,7 @@ readmem(ulonglong addr, int memtype, void *buffer,
long size,
case PAGE_EXCLUDED:
RETURN_ON_PARTIAL_READ();
- if (CRASHDEBUG(8))
+ if (PRINT_ERROR_MESSAGE)
error(INFO, PAGE_EXCLUDED_ERRMSG,
memtype_string(memtype, 0), addr, type);
goto readmem_error;
--
2.50.0
Attachments:
- attachment.html (text/html — 3.3 KB)