Re: [Crash-utility] [PATCH] Fix x86 initialization for {hard, soft}irq_ctx
----- Original Message -----
Dave Anderson <anderson(a)redhat.com> writes:
> but we stopped supporting 32-bit x86 in RHEL7. And nobody ever
> reported it from any other x86 kernel sources.
Ah, I see. I didn't know RHEL7 dropped support of x86.
And because of that, I've pretty much dropped tracking later x86 kernels
in the crash utility, so it's not surprising that there may be other issues.
> I also note that in linux-3.15 the data structure name and variables were
> changed to:
>
> struct irq_stack {
> u32 stack[THREAD_SIZE/sizeof(u32)];
> } __aligned(THREAD_SIZE);
>
> DECLARE_PER_CPU(struct irq_stack *, hardirq_stack);
> DECLARE_PER_CPU(struct irq_stack *, softirq_stack);
>
> So your patch would need more work for 3.15 and later kernels.
Right. That patch is for "per_cpu + irq_ctx" kernel.
Supporting irq_stack itself would be easy. But current x86 crash doesn't
work for v4.9 (still using irq_stack), this is because current kernel
changed switch_to() stack frame format (need to do similar with x86_64).
Our last emails crossed, where I at least got the hardirq_ctx[] array to
set up correctly. But I would appreciate any other work you'd like to
do with the x86 architecture.
Thanks,
Dave