[Crash-utility] Re: [PATCH] Reflect __{start,end}_init_task kernel symbols rename
Hi, Alexander
Thank you for the early fix.
On 4/10/24 22:15, devel-request(a)lists.crash-utility.osci.io wrote:
Date: Wed, 10 Apr 2024 14:55:35 +0200
From: Alexander Gordeev<agordeev(a)linux.ibm.com>
Subject: [Crash-utility] [PATCH] Reflect __{start,end}_init_task
kernel symbols rename
To:devel@lists.crash-utility.osci.io
Cc: Alexander Egorenkov<egorenar(a)linux.ibm.com>
Message-ID:<20240410125535.2891355-1-agordeev@linux.ibm.com>
Kernel commit 8f69cba096b5 ("x86: Rename __{start,end}_init_task to
__{start,end}_init_stack") leads to failure:
crash: invalid count request: 0
Could you please point out which command caused the current failure? or
failed when crash load?
Anyway, the code changes are fine to me.
Thanks
Lianbo
Assume both __{start,end}_init_task and __{start,end}_init_stack
symbols could exist for backward compatibility.
Signed-off-by: Alexander Gordeev<agordeev(a)linux.ibm.com>
---
task.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/task.c b/task.c
index ebdb5be..88e1d50 100644
--- a/task.c
+++ b/task.c
@@ -496,10 +496,17 @@ task_init(void)
((len = SIZE(thread_union)) != STACKSIZE())) {
machdep->stacksize = len;
} else if (!VALID_SIZE(thread_union) && !VALID_SIZE(task_union)) {
+ len = 0;
if (kernel_symbol_exists("__start_init_task") &&
kernel_symbol_exists("__end_init_task")) {
len = symbol_value("__end_init_task");
len -= symbol_value("__start_init_task");
+ } else if (kernel_symbol_exists("__start_init_stack") &&
+ kernel_symbol_exists("__end_init_stack")) {
+ len = symbol_value("__end_init_stack");
+ len -= symbol_value("__start_init_stack");
+ }
+ if (len) {
ASSIGN_SIZE(thread_union) = len;
machdep->stacksize = len;
}
-- 2.40.1