Re: [Crash-utility] [v3 0/2] sbitmapq command

-----Original Message----- > The first patch adds the sbitmapq command to the crash. The second > adds '-p' option for sbitmapq command. The option says that > an associated with sbitmap_queue array contains the pointers of data. Thank you for the v3, the option is totally what I wanted. I've confirmed that it looked ok with blk_mq_tags.bitmap_tags and .rqs array. crash> sbitmapq 0xffff916f6ebe8850 -s request.q -a 0xffff916f55111f00 -p -v 7 (0xffff916f55111f38): q = 0xffff916f64181420, 22 (0xffff916f55111fb0): q = 0xffff916f64181420, The patchset looks good to me. Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt; Lianbo, a few adjustments were needed to "git am" as we merged the safe buffer patches, and modified the commit logs a little. Attached.

Thanks, Kazu > > > Sergey Samoylenko (2): > sbitmapq command > '-p' option for sbitmapq command > > Makefile | 7 +- > defs.h | 59 +++++ > global_data.c | 1 + > help.c | 105 ++++++++ > sbitmap.c | 677 ++++++++++++++++++++++++++++++++++++++++++++++++++ > symbols.c | 39 +++ > 6 files changed, 886 insertions(+), 2 deletions(-) > create mode 100644 sbitmap.c > > -- > 2.25.1