Re: [Crash-utility] [PATCH v3 0/1] Filter ps output by scheduling policy

Hi Oleksandr, I finally got around to doing a code review today, and ended up making a few minor changes to your patch: (1) Instead of defaulting to NORMAL, invalid arguments generate a FATAL error. (2) I reworded the help page entry, and moved it up into the restricted process section instead of down in the "alternatives" section. (3) I moved the offset_table[] and size_table[] task_struct_policy members to the end of the arrays to prevent any breakage of pre-compiled extension modules. (4) Display the task_struct_policy offset and size table values in the dump_offset_table() function for "help -o". (5) Replaced the strdup() call with STRDUPBUF(), calloc() with GETBUF(), and free() calls with FREEBUF() to avoid using them during runtime. But I need you to re-work your sched_policy_bit_from_str() function so that it will accept a hexadecimal number, i.e, "ps -y 0x2". Granted it's not explicitly allowed in the help page, but a user may see the policy expressed as a hexadecimal value by "task" or "struct", and it seems too picky to just disallow it. I've attached an updated version of the patch with the changes above. Thanks, Dave ----- Original Message -----