[Crash-utility] Re: [PATCH] vmcoreinfo: read vmcoreinfo using 'vmcoreinfo_data' when unavailable in elf note

Hi, Aditya Thank you for the patch. On Wed, Jun 18, 2025 at 1:33 PM Aditya Gupta <adityag(a)linux.ibm.com&gt; wrote: > <...snip...> > > +/** > + * Check if vmcoreinfo in vmcore is missing/empty > + */ > +static bool is_vmcoreinfo_empty(void) > +{ > + return (dd->sub_header_kdump->size_vmcoreinfo == 0); > +} > > I have seen two versions of the implementation, another one is in netdump.c. Can we do it like this? bool is_vmcoreinfo_empty(void) { if (dd && dd->sub_header_kdump) return (dd->sub_header_kdump->size_vmcoreinfo == 0); if (nd) return (nd->size_vmcoreinfo == 0); return true; } And implement it in a common file, E.g: kernel.c, put its definition to defs.h. So that we can call this one in netdump.c and diskdump.c. What do you think?

Other changes are fine to me.

Thanks Lianbo