Re: [Crash-utility] [PATCH v2] struct: Allow -r with a single member-specific output
Hi Dave,
Dave Anderson wrote on Wed, Apr 01, 2020:
> I didn't post that v2 back in Feb because I wasn't
totally happy with
> it; I can't say I now am but might as well get your take on it...
What part of this patch aren't you happy about?
It's mostly style really - I don't like that we're calling in twice in
datatype_info(), because member_to_datatype() doesn't really fill in the
datatype_member struct and only fills in dm->member and offset.
At a naive read, I would expect member_to_datatype to fill in the whole
dm...
Functionally I tested it, it's a bit slower than my original version but
not enough to be a valid argument here; it's much better than nothing so
if you're happy with this let's go with it :)
I will probably want to follow up with a second patch for raw_data_dump
to add DISPLAY_32/16 flags if the len requested is < word size but it's
not directly related to this patch...
Cheers,
--
Dominique