Re: [Crash-utility] [PATCH] arm64: handle vabits_actual symbol missing case
On 2022/12/12 12:34, lijiang wrote:
Thank you for the update, Pavankumar.
On Thu, Dec 8, 2022 at 1:08 PM <crash-utility-request(a)redhat.com> wrote:
> Date: Thu, 8 Dec 2022 09:55:07 +0530
> From: Pavankumar Kondeti <quic_pkondeti(a)quicinc.com>
> To: <crash-utility(a)redhat.com>, <k-hagio-ab(a)nec.com>
> Cc: <quic_ankban(a)quicinc.com>, Pavankumar Kondeti
> <quic_pkondeti(a)quicinc.com>
> Subject: [Crash-utility] [PATCH] arm64: handle vabits_actual symbol
> missing case
> Message-ID:
> <1670473507-29911-1-git-send-email-quic_pkondeti(a)quicinc.com>
> Content-Type: text/plain
>
> After the commit 0d9b1ffefabe ("arm64: mm: make vabits_actual
> a build time constant if possible") introduced in v5.19
> Linux kernel, the crash will not find vabits_actual symbol
> if if VA_BITS <= 48. Add a fallback option to initialize VA_BITS
^^^^
Thanks, fixed and applied.
https://github.com/crash-utility/crash/commit/141e75f3c11c
Kazu
>
>> based on the user supplied machdep option.
>>
>> Tested ramdumps loading in both 6.0 and 5.15 kernels.
>>
>> Signed-off-by: Pavankumar Kondeti <quic_pkondeti(a)quicinc.com>
>> ---
>> arm64.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arm64.c b/arm64.c
>> index c3e26a3..7125458 100644
>> --- a/arm64.c
>> +++ b/arm64.c
>> @@ -4671,6 +4671,10 @@ arm64_calc_VA_BITS(void)
>> return;
>> } else if (arm64_set_va_bits_by_tcr()) {
>> return;
>> + } else if (machdep->machspec->VA_BITS_ACTUAL) {
>> + machdep->machspec->VA_BITS =
machdep->machspec->VA_BITS_ACTUAL;
>> + machdep->machspec->VA_START =
_VA_START(machdep->machspec->VA_BITS_ACTUAL);
>> + return;
>> }
>>
>
> Looks good to me, for the v2: Ack
>
> Thanks.
> Lianbo
>
>> if (!(sp = symbol_search("swapper_pg_dir")) &&
>> --
>> 2.7.4
>
> --
> Crash-utility mailing list
> Crash-utility(a)redhat.com
> https://listman.redhat.com/mailman/listinfo/crash-utility
> Contribution Guidelines: https://github.com/crash-utility/crash/wiki