Re: [Crash-utility] [PATCH 0/2] sparc64 support for crash utility

Hi Dave, Welcome to the party after all these years. With any new architecture addition, one of the primary requirements for acceptance is that it in no way impacts any of the other architectures. This patchset was nicely done with that in mind, although there are two places in task.c where it does modify generic code: First, I prefer that the change in get_idle_threads() be segregated for SPARC64 only. The second change to task_flags() looks reasonable, but I would prefer that it be done differently. The reason it reads the flags with ULONG() is because originally it was an unsigned long. I'm not sure when the kernel changed it to an unsigned int, but interestingly enough, it's never been reported as a problem. In any case, to maintain backwards compatibility with older kernels, the read size should be based upon MEMBER_SIZE() instead of forcing it to use UINT() as you have done. And as far as sparc64.c, I did look at it, and it looks fine on paper, but I'll give you free reign as the sparc64 maintainer to do with it as you like. You will be my go-to sparc64 maintainer, correct? Dave ----- Original Message -----