[Crash-utility] Re: [PATCH] Ensure all child processes are properly cleaned up in restore_ifile_sanity
Hi, Feng
Thank you for the patch. This looks good to me, so: Ack.
Lianbo
On 1/28/26 9:42 AM, devel-request(a)lists.crash-utility.osci.io wrote:
Date: Wed, 3 Dec 2025 10:35:57 +0800
From: neilfsun<loyou85(a)gmail.com>
Subject: [Crash-utility] [PATCH] Ensure all child processes are
properly cleaned up in restore_ifile_sanity
To:devel@lists.crash-utility.osci.io
Cc: neilfsun<neilfsun(a)tencent.com>, Feng Sun<loyou85(a)gmail.com>
Message-ID:<20251203023557.55333-1-neilfsun@tencent.com>
Run input file with pipe cmdlines will get nothing output.
crash> p cpu_info:0 | grep 'x86 ='
x86 = 0x19,
crash> cat crashrc
p cpu_info:0 | grep 'x86 ='
p cpu_info:0 | grep 'x86 ='
crash> < crashrc
crash> p cpu_info:0 | grep 'x86 ='
x86 = 0x19,
crash> p cpu_info:0 | grep 'x86 ='
crash>
Signed-off-by: neilfsun<neilfsun(a)tencent.com>
Signed-off-by: Feng Sun<loyou85(a)gmail.com>
---
cmdline.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/cmdline.c b/cmdline.c
index 65da04c..4add548 100644
--- a/cmdline.c
+++ b/cmdline.c
@@ -1285,6 +1285,8 @@ restore_ifile_sanity(void)
close_tmpfile2();
}
+ wait_for_children(ALL_CHILDREN);
+
restore_gdb_sanity();
free_all_bufs();
-- 2.50.1