Re: [Crash-utility] Re: [PATCH] s390: Make page table functions more generic

Michael Holzheu wrote: > Hi Dave, > > For s390(x) kernels the page table allocation method will be changed. > Instead of 3 levels, it will be now possible to allocate 4 levels. > > The current implementation of the page table walk functions in crash > makes assumptions on how the page tables are allocated by the kernel. > E.g. three levels are hard coded. > > This patch changes that and the page table walk is done only according > to the s390 architecture without assumptions on the implementation in > the kernel. > > So both old and new kernels are supported. > Hi Michael, I have complete faith in you... ;-) And this certainly simplifies things considerably, which is always good. But -- can you give me a warm-and-fuzzy feeling by confirming that you tested this on a RHEL kernel? And that "make warn" compiles cleanly?