[Crash-utility] Re: [PATCH] LoongArch64: fix incorrect code in the main()

The commit c3939d2e1930 contains incorrect code that starts with "+", for example: - !machine_type("S390X") && !machine_type("RISCV64")) + !machine_type("S390X") && !machine_type("RISCV64") && ++ !machine_type("LOONGARCH64")) See the main() in the main.c ... } else if (STREQ(long_options[option_index].name, "kaslr")) { if (!machine_type("X86_64") && !machine_type("ARM64") && !machine_type("X86") && !machine_type("S390X") && !machine_type("RISCV64") && + !machine_type("LOONGARCH64")) Let's remove it from the main().

Link: https://lists.crash-utility.osci.io/archives/list/devel@lists.crash-utili... Fixes: c3939d2e1930 ("LoongArch64: Add "--kaslr" command line option support") Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt; --- main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.c b/main.c index 0b6b9273ab06..71bcc1558192 100644 --- a/main.c +++ b/main.c @@ -229,7 +229,7 @@ main(int argc, char **argv) if (!machine_type("X86_64") && !machine_type("ARM64") && !machine_type("X86") && !machine_type("S390X") && !machine_type("RISCV64") && -+ !machine_type("LOONGARCH64")) + !machine_type("LOONGARCH64")) error(INFO, "--kaslr not valid " "with this machine type.\n"); else if (STREQ(optarg, "auto")) -- 2.45.1 -- Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki