Re: [Crash-utility] [PATCH v2] kmem: Add support to -S option to specify a range of CPU-specific slab data

-----Original Message----- I see. I think that it's good to have a way to know which CPUs are offline without the offline hide option by another patch, as crash shows only the number of offline CPUs when startup. display_sys_stats() might be a good place to do something about it, a simple example: # crash ... DUMPFILE: /proc/kcore CPUS: 16 [OFFLINE: 2 (CPU: 14,15)] --- a/kernel.c +++ b/kernel.c @@ -5627,9 +5627,22 @@ display_sys_stats(void) fprintf(fp, " CPUS: %d\n", get_cpus_to_display()); else { fprintf(fp, " CPUS: %d", kt->cpus); - if (kt->cpus - get_cpus_to_display()) - fprintf(fp, " [OFFLINE: %d]", - kt->cpus - get_cpus_to_display()); + if (kt->cpus - get_cpus_to_display()) { + int i; + char *p = buf; + BZERO(buf, BUFSIZE); + for (i = 0; i < kt->cpus; i++) { + if (check_offline_cpu(i)) { + if (p == buf) + sprintf(p, "%d", i); + else + sprintf(p, ",%d", i); + p += strlen(p); + } + } + fprintf(fp, " [OFFLINE: %d (CPU: %s)]", + kt->cpus - get_cpus_to_display(), buf); + } fprintf(fp, "\n"); } Thanks, Kazu