Re: [Crash-utility] [PATCH] vmware: Improve output when we fail to read vmware 'vmsn' file

> @@ -112,8 +112,8 @@ vmware_vmss_init(char *filename, FILE *ofp) > } > > if (fread(grps, sizeof(cptgroupdesc), grpsize, fp) != grpsize) { > - error(INFO, LOGPRX"Failed to read '%s': [Error %d] %s\n", > - filename, errno, strerror(errno)); > + error(INFO, LOGPRX"Failed to read '%s' from file '%s': > [Error %d] %s\n", > + "cptgroupdesc", filename, errno, strerror(errno)); > ^^^^^^^^^^^^ Although the above code is good, I tend to output constant strings directly rather than using the '%s' to print. Anyway, the other changes still look fine to me. So: Ack.