Re: [Crash-utility] [PATCH v4] files: support dump file memory mapping

Dave, I reviewed all you changes. It looked good to me. It seemed your patch had some trailing whitespace issues. Just FYI. $ git apply ~/files_v5.patch/home/oliver/files_v5.patch:35: trailing whitespace." %s> files -c 1954",/home/oliver/files_v5.patch:259: trailing whitespace. count, nrpages);/home/oliver/files_v5.patch:362: trailing whitespace. mkstring(buf2, MAX(VADDR_PRLEN, strlen("I_MAPPING")),warning: 3 lines add whitespace errors. From: yang_oliver(a)hotmail.com To: crash-utility(a)redhat.com Date: Wed, 1 Jul 2015 00:00:12 +0000 Subject: Re: [Crash-utility] [PATCH v4] files: support dump file memory mapping Date: Tue, 30 Jun 2015 17:02:53 -0400 From: anderson(a)redhat.com To: crash-utility(a)redhat.com Subject: Re: [Crash-utility] [PATCH v4] files: support dump file memory mapping ----- Original Message ----- Hi Oliver, I've attached the patch for your review. In addition to the items listed above, I also made a few other minor changes to better handle some error conditions I ran into while testing the patch, I renamed a few functions and macros to be more related to their actual purpose, globally exposed just the single-page dump callback function, and made it return a legitimate return value. (And there may be other minor changes that I can't remember.) Let me know what you think about the changes, and if we're in agreement, I'll check it in tomorrow. -- Crash-utility mailing list Crash-utility(a)redhat.com https://www.redhat.com/mailman/listinfo/crash-utility