Thanks a lot, Steve -- forwarding to the crash-utility mainling list and to Xu Huan,
the trace.c maintainer for his ACK.
There was a report on this list about the sp_type problem last week, but the proposed fix
(which just changed all module symbol sp_type's to '?' in the crash utility
itself) wasn't
acceptable, and there was no response after that. This looks to fix the same issue.
Dave
----- Forwarded Message -----
From: "Steven Rostedt" <rostedt(a)goodmis.org>
To: "Dave Anderson" <anderson(a)redhat.com>
Sent: Friday, March 15, 2019 9:03:33 PM
Subject: [PATCH 0/3] trace.so: Make trace dump -t work again
Hi Dave,
I gave a talk at SCaLE 17x last week and was going to demonstrate using
ftrace on a system that crashes, and then pulling out the vmcore file
with kexec and kdump, and then pulling out the ftrace ring buffers and
creating a trace.dat file with the crash extension trace.so.
Unfortunately, this wasn't working as I planned. I created the
following three patches, where two fix the issue (I was getting a
corrupted trace.dat file), and the third actually documents the '-t'
option of the dump command. Hopefully you can accept these patches.
Thanks!
-- Steve
-----
extensions/trace.c | 32 +++++++++++++++++++++++++++++---
1 file changed, 29 insertions(+), 3 deletions(-)
Steven Rostedt (VMware) (3):
trace.so: Do not record empty pages
trace.so: Do not print garbage for kallsyms "type" for modules
trace.so: Show -t option in trace dump short help message