Hi, Sven
On Fri, Jul 8, 2022 at 3:32 PM Sven Schnelle <svens(a)linux.ibm.com> wrote:
Hi Lianbo,
lijiang <lijiang(a)redhat.com> writes:
> This Message Is From an External Sender
> This message came from outside your organization.
> Thank you for the reply, Sven.
>
> On Thu, Feb 10, 2022 at 2:37 PM Sven Schnelle <svens(a)linux.ibm.com>
wrote:
>
> Hi,
>
> lijiang <lijiang(a)redhat.com> writes:
>
> > This Message Is From an External Sender
> > This message came from outside your organization.
> > Hi, Sven and Kazu
> >
> > The patchset really saves compilation time for crash build and the
following three patches look good to me(need a
> minor
> > adjustment as Kazu mentioned).
> > Thank you for the work, Sven.
> >
> > [PATCH v2 1/4] make: set --no-print-directory once
> > [PATCH v2 3/4] make: use -C instead of (cd x; make)
> > [PATCH v2 4/4] make: replace make by $(MAKE)
> >
> > Given that the gdb patch has specific rules, Kazu(or me) can help to
> > pack them into one patch with Sven's signature, if you have no
objections.
>
> Sorry, i was busy with other stuff. If you could fix that patching issue
> (i haven't really looked into this), that would be great!
>
>
> No worries. I will discuss this one with Kazu later, once ready, we will
try to merge it.
I've just looked through the commits, and it looks like this patch was
never adjusted/merged. Do you think you can change that one and push it,
or should i try to do it and re-submit?
It has been merged into the crash-7-branch and master branch. Could you
please check it again?
commit 74ac929712416705a758f14a3506991bbfdc869c
Author: Sven Schnelle <svens(a)linux.ibm.com>
Date: Mon Dec 20 14:16:50 2021 +0100
Support for multiple jobs to build crash
This patch saves compilation time for crash build, which did the
following things:
[1] add --no-print-directory to MAKEFLAGS right in the beginning
to avoid repeating it in all make calls.
[2] use "make -C" instead of "cd x; make"
[3] replace make by $(MAKE)
Link:
https://listman.redhat.com/archives/crash-utility/2021-December/msg00049....
Link:
https://listman.redhat.com/archives/crash-utility/2021-December/msg00048....
Link:
https://listman.redhat.com/archives/crash-utility/2021-December/msg00047....
Signed-off-by: Sven Schnelle <svens(a)linux.ibm.com>
Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com>
And the commit in crash-7-branch is:
2b3215df7212 ("Support for multiple jobs to build crash")
Thanks.
Lianbo
Thanks
Sven