Re: [Crash-utility] [PATCH] extensions/eppic.mk: Remove ping checkto github.com
Hi Lianbo,
-----Original Message-----
>>> -GITHUB := $(shell ping -c 1 github.com | grep "1
received")
>> BTW: Is it possible to fix this issue with the option -W? For example:
>>
>> GITHUB := $(shell ping -c 1 -W 2 github.com | grep "1 received")
>> ^^^^
> No, this doesn't solve the former issue in an environment where ping
> doesn't work but "git clone" does work. I have such an environment..
>
Interesting. Seems that ping doesn't work because of the network policy
or other reason?
Probably it's the network policy.
For my side, the -W option will provide a timeout.
> In the first place, what is the ping check needed for? I'm not sure
> why it is there. If it's for avoiding long timeout of "git clone",
> it would not be solved by the ping check everywhere, i.e. in a place
> where ping works but git clone doesn't work. In this case, something
> like "timeout 20 git clone ..." might be better.
>
This still depends on the network speed.
Anyway, this change looks good. Acked-by: Lianbo Jiang <lijiang(a)redhat.com>
Thanks, but sorry, I've changed my mind..
For safety, I would like to keep the ping check, and I will give up
the automated "git clone" in the specific environment. I found that
I can build it by manual "git clone" and "make extensions".
Could you check the following patch again?
From dd4bf22a49b36141afb0c0912171170b8ab2ae01 Mon Sep 17 00:00:00 2001
From: Kazuhito Hagio <k-hagio-ab(a)nec.com>
Date: Wed, 23 Dec 2020 16:38:41 +0900
Subject: [PATCH] extensions/eppic.mk: move ping check to recipe script
Without this patch, in an environment where ping to github.com does
not work, "make clean" at the top-level crash directory always takes
about 10 seconds unnecessarily.
$ time make clean
...
real 0m10.398s
Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
---
extensions/eppic.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/extensions/eppic.mk b/extensions/eppic.mk
index c79170a596b7..bda69da6706f 100644
--- a/extensions/eppic.mk
+++ b/extensions/eppic.mk
@@ -24,7 +24,6 @@ ifeq ($(TARGET), X86)
endif
APPFILE=eppic/applications/crash/eppic.c
-GITHUB := $(shell ping -c 1 github.com | grep "1 received")
GIT := $(shell which git 2> /dev/null)
all:
@@ -38,7 +37,7 @@ all:
if [ -n "$(EPPIC_GIT_URL)" ]; then \
git clone "$(EPPIC_GIT_URL)" eppic; \
else \
- if [ -n "$(GITHUB)" ] ; then \
+ if ping -c 1 -W 5 github.com >/dev/null ; then \
git clone https://github.com/lucchouina/eppic.git eppic; \
fi; \
fi; \
--
2.18.4