Re: [Crash-utility] [External Mail]Re: [PATCH] Bugfix and optimization for ARM64 getting crash notes
----- Original Message -----
Hi Dave,
I find 32-bit arm has the same issue, so the patch should also been applied to 32-bit
arm.
Since I have no 32-bit arm kdump in hand, could you pls help test for the attached
patch?
Best regards,
Qiwu
Your patch doesn't compile -- as shown here in a tree originally created with
"make target=ARM":
$ make
TARGET: ARM
CRASH: 7.2.8rc23
GDB: 7.6
cc -c -g -DARM -m32 -D_FILE_OFFSET_BITS=64 -DLZO -DSNAPPY -DGDB_7_6 build_data.c
cc -c -g -DARM -m32 -D_FILE_OFFSET_BITS=64 -DLZO -DSNAPPY -DGDB_7_6 arm.c
arm.c: In function ‘arm_get_crash_notes’:
arm.c:556:3: warning: ‘return’ with a value, in function returning void [enabled by
default]
return FALSE;
^
arm.c:661:10: error: ‘struct machine_specific’ has no member named ‘panic_task_regs’
free(ms->panic_task_regs);
^
arm.c:662:5: error: ‘struct machine_specific’ has no member named ‘panic_task_regs’
ms->panic_task_regs = NULL;
^
make[4]: *** [arm.o] Error 1
make[3]: *** [gdb] Error 2
make[2]: *** [rebuild] Error 2
make[1]: *** [gdb_merge] Error 2
make: *** [all] Error 2
$
I fixed the errors and checked it in for crash-7.2.8:
https://github.com/crash-utility/crash/commit/63df9c067de0b2017f50f5d2369...
Thanks,
Dave