Re: [Crash-utility] [PATCH 0/4] Fix for "sbitmapq" command
Hi Lianbo,
On 2022/05/23 19:04, Lianbo Jiang wrote:
The sbitmapq command will fail due to the following kernel commit:
[1] commit <c548e62bcf6a> ("scsi: sbitmap: Move allocation hint
into sbitmap")
[2] commit <efe1f3a1d583> ("scsi: sbitmap: Maintain allocation
round_robin in sbitmap")
[3] commit <3301bc53358a> ("lib/sbitmap: kill 'depth' from
sbitmap_word")
Without the patchset, the sbitmapq won't work.
Good job! The patchset looks nice and clean to me, tested ok with
some kernels up to 5.18. Applied with some small adjustments.
btw, do you want to use the "<commid id>" style in crash's commit
log?
I think it's not so common, so removed the brackets this time.
Thanks,
Kazu
>
> Lianbo Jiang (4):
> sbitmapq: a cleanup in the sbitmapq_init()
> sbitmapq: fix invalid offset for "sbitmap_queue_alloc_hint" on linux
> v5.13-rc1
> sbitmapq: fix invalid offset for "sbitmap_queue_round_robin" on linux
> v5.13-rc1
> sbitmapq: fix invalid offset for "sbitmap_word_depth" on linux
> v5.18-rc1
>
> defs.h | 4 ++++
> sbitmap.c | 70 +++++++++++++++++++++++++++----------------------------
> symbols.c | 4 ++++
> 3 files changed, 42 insertions(+), 36 deletions(-)
>