Re: [Crash-utility] [PATCH 1/2] s390dbf: remove raw-view from s390dbf

Hi Lianbo, Bhupesh, Is it possible for both of you to review/test this patchset?

i.e. merge without my ack. It would be better to test on real machine and the vmcores for test that Dave left. Thanks, Kazu -----Original Message----- > With kernel commit ecb1ff6833 "s390/debug: remove raw view" the raw-view > is no longer supported by s390 debug feature. > Since there has never been a single user of the raw-view, remove it from > crash as well. > > Signed-off-by: Mikhail Zaslonko <zaslonko(a)linux.ibm.com&gt; > --- > s390dbf.c | 42 ------------------------------------------ > 1 file changed, 42 deletions(-) > > diff --git a/s390dbf.c b/s390dbf.c > index f21cd3a..232ceb8 100644 > --- a/s390dbf.c > +++ b/s390dbf.c > @@ -378,40 +378,6 @@ dflt_header_fn(debug_info_t * id, debug_view_t *view, > return rc; > } > > -/* > - * prints debug header in raw format > - */ > -static int > -raw_header_fn(debug_info_t * id, debug_view_t *view, > - int area, debug_entry_t * entry, char *out_buf) > -{ > - int rc; > - > - rc = sizeof(debug_entry_t); > - if (out_buf == NULL) > - goto out; > - memcpy(out_buf,entry,sizeof(debug_entry_t)); > - out: > - return rc; > -} > - > -/* > - * prints debug data in raw format > - */ > -static int > -raw_format_fn(debug_info_t * id, debug_view_t *view, > - char *out_buf, const char *in_buf) > -{ > - int rc; > - > - rc = id->buf_size; > - if (out_buf == NULL || in_buf == NULL) > - goto out; > - memcpy(out_buf, in_buf, id->buf_size); > - out: > - return rc; > -} > - > /* > * prints debug data in hex/ascii format > */ > @@ -682,13 +648,6 @@ debug_view_t pages_view = { > NULL, > }; > > -debug_view_t raw_view = { > - "raw", > - NULL, > - &raw_header_fn, > - &raw_format_fn, > -}; > - > debug_view_t hex_ascii_view = { > "hex_ascii", > &prolog_fn, > @@ -899,7 +858,6 @@ dbf_init(void) > add_lcrash_debug_view(&hex_view); > add_lcrash_debug_view(&hex_ascii_view); > add_lcrash_debug_view(&sprintf_view); > - add_lcrash_debug_view(&raw_view); > ebcdic_ascii_conv = iconv_open("ISO-8859-1", "EBCDIC-US"); > initialized = 1; > } > -- > 2.17.1